v good

src/audio/piano-sampler.ts

@@ -58,15 +58,6 @@ export class PianoSampler {
 
     const sample = this.findNearestSample(midi);
     if (!sample) {
-      this.playFallbackPluck({
-        midi,
-        velocity,
-        startTime,
-        durationSeconds,
-        pan,
-        delaySend,
-        lowpassHz,
-      });
       return;
     }
 
@@ -84,7 +75,8 @@ export class PianoSampler {
       (this.engineConfig.piano.sustainBase +
         noteVelocity * this.engineConfig.piano.sustainVelocityRange);
     const sustainAt =
-      scheduledStart + Math.max(this.engineConfig.piano.minDurationSeconds, durationSeconds);
+      scheduledStart +
+      Math.max(this.engineConfig.piano.minDurationSeconds, durationSeconds);
     const releaseAt = sustainAt + sustainSeconds;
     const releaseSeconds = this.config.piano.releaseSeconds;
     const stopAt = releaseAt + releaseSeconds;
@@ -108,10 +100,7 @@ export class PianoSampler {
 
     source.buffer = sample.buffer;
     source.playbackRate.setValueAtTime(
-      Math.pow(
-        2,
-        (midi - sample.midi) / this.engineConfig.piano.pitchSemitonesPerOctave
-      ),
+      Math.pow(2, (midi - sample.midi) / this.engineConfig.piano.pitchSemitonesPerOctave),
       scheduledStart
     );
     filter.type = 'lowpass';
@@ -140,11 +129,7 @@ export class PianoSampler {
         sustainSeconds * this.engineConfig.piano.sustainBase
       )
     );
-    gain.gain.setTargetAtTime(
-      this.engineConfig.piano.minGain,
-      releaseAt,
-      releaseSeconds
-    );
+    gain.gain.setTargetAtTime(this.engineConfig.piano.minGain, releaseAt, releaseSeconds);
     panner.pan.setValueAtTime(clamp(pan, -1, 1), scheduledStart);
 
     source.connect(filter);
@@ -196,90 +181,4 @@ export class PianoSampler {
   private trimActiveVoices(now: number): void {
     this.activeVoices = this.activeVoices.filter((voice) => voice.stopAt > now);
   }
-
-  private playFallbackPluck({
-    midi,
-    velocity,
-    startTime,
-    durationSeconds,
-    pan,
-    delaySend = 0,
-    lowpassHz = this.config.piano.lowpassHz,
-  }: PianoNote): void {
-    const { context, eventBus, delayInput } = this.graph;
-    if (!context || !eventBus) {
-      return;
-    }
-
-    const scheduledStart = Math.max(
-      context.currentTime + this.engineConfig.piano.scheduleAheadSeconds,
-      startTime
-    );
-    const oscillator = context.createOscillator();
-    const filter = context.createBiquadFilter();
-    const gain = context.createGain();
-    const panner = context.createStereoPanner();
-    let sendGain: GainNode | null = null;
-    const noteVelocity = clamp01(velocity);
-    const noteGainValue = Math.max(
-      this.engineConfig.piano.minGain,
-      this.config.piano.gain * noteVelocity * 0.42
-    );
-    const releaseAt =
-      scheduledStart + Math.max(this.engineConfig.piano.minDurationSeconds, durationSeconds);
-    const stopAt = releaseAt + this.config.piano.releaseSeconds;
-
-    oscillator.type = 'triangle';
-    oscillator.frequency.setValueAtTime(
-      440 * Math.pow(2, (midi - 69) / appConfig.audioEngine.piano.pitchSemitonesPerOctave),
-      scheduledStart
-    );
-    filter.type = 'lowpass';
-    filter.frequency.setValueAtTime(
-      clamp(
-        lowpassHz * 0.72,
-        this.engineConfig.piano.lowpassMinHz,
-        this.engineConfig.piano.lowpassMaxHz
-      ),
-      scheduledStart
-    );
-    filter.Q.value = this.engineConfig.piano.filterQ;
-    gain.gain.setValueAtTime(this.engineConfig.piano.minGain, scheduledStart);
-    gain.gain.exponentialRampToValueAtTime(
-      noteGainValue,
-      scheduledStart + this.engineConfig.piano.gainAttackSeconds
-    );
-    gain.gain.setTargetAtTime(
-      this.engineConfig.piano.minGain,
-      releaseAt,
-      this.config.piano.releaseSeconds
-    );
-    panner.pan.setValueAtTime(clamp(pan, -1, 1), scheduledStart);
-
-    oscillator.connect(filter);
-    filter.connect(gain);
-    gain.connect(panner);
-    panner.connect(eventBus);
-
-    if (delayInput && delaySend > 0) {
-      sendGain = context.createGain();
-      sendGain.gain.value = delaySend * 0.5;
-      panner.connect(sendGain);
-      sendGain.connect(delayInput);
-    }
-
-    oscillator.start(scheduledStart);
-    oscillator.stop(stopAt + this.engineConfig.piano.tailStopExtraSeconds);
-    oscillator.addEventListener(
-      'ended',
-      () => {
-        oscillator.disconnect();
-        filter.disconnect();
-        gain.disconnect();
-        panner.disconnect();
-        sendGain?.disconnect();
-      },
-      { once: true }
-    );
-  }
 }