Parse dashboard operators independently of quoted filter values

This commit is contained in:
Andras Schmelczer 2026-10-27 20:02:40 +00:00
commit 1fda2d6fc0

View file

@ -0,0 +1,32 @@
from typing import Any
import pytest
from great_ai.deploy.routes.dashboard.get_filter_from_datatable import (
get_filter_from_datatable,
)
@pytest.mark.parametrize(
"expression, operator, value",
[
('{value} contains "a=b"', "contains", "a=b"),
("{value} eq 7", "=", 7),
("{value} ge 2.5", ">=", 2.5),
('{value} contains ""', "contains", ""),
(r"{value} contains 'it\'s > 2'", "contains", "it's > 2"),
],
)
def test_dashboard_filter_grammar(expression: str, operator: str, value: Any) -> None:
result = get_filter_from_datatable(expression)
assert result is not None
assert result.property == "value"
assert result.operator == operator
assert result.value == value
@pytest.mark.parametrize(
"expression", ["{value} > ", '{value} contains "unfinished', "invalid"]
)
def test_incomplete_filters_are_ignored(expression: str) -> None:
assert get_filter_from_datatable(expression) is None