Read every page of S3 model versions
This commit is contained in:
parent
17d83126c7
commit
a2334f4bbd
2 changed files with 46 additions and 19 deletions
|
|
@ -93,7 +93,7 @@ def test_initialized_with_dict(client: Any) -> None:
|
|||
)
|
||||
|
||||
s3.list_objects_v2.assert_called_once_with(
|
||||
Bucket=credentials["large_files_bucket_name"], Prefix="test-file"
|
||||
Bucket=credentials["large_files_bucket_name"], Prefix="test-file/"
|
||||
)
|
||||
|
||||
assert lf._version == 2
|
||||
|
|
@ -137,7 +137,7 @@ def test_initialized_with_file(client: Any) -> None:
|
|||
|
||||
assert s3.list_objects_v2.called
|
||||
s3.list_objects_v2.assert_called_once_with(
|
||||
Bucket=credentials["large_files_bucket_name"], Prefix="test-file"
|
||||
Bucket=credentials["large_files_bucket_name"], Prefix="test-file/"
|
||||
)
|
||||
|
||||
assert lf._version == 2
|
||||
|
|
|
|||
|
|
@ -121,3 +121,29 @@ def test_gridfs_matches_only_exact_model_names() -> None:
|
|||
reader = LargeFileMongo("model")
|
||||
assert reader.version == 0
|
||||
assert [instance.name for instance in reader._instances] == ["model"]
|
||||
|
||||
|
||||
def test_s3_follows_every_listing_page() -> None:
|
||||
backend = MagicMock()
|
||||
backend.list_objects_v2.side_effect = [
|
||||
{
|
||||
"Contents": [{"Key": "model/0"}, {"Key": "model-other/99"}],
|
||||
"IsTruncated": True,
|
||||
"NextContinuationToken": "next",
|
||||
},
|
||||
{
|
||||
"Contents": [
|
||||
{"Key": "model/9"},
|
||||
{"Key": "model/backup"},
|
||||
{"Key": "model/9/extra"},
|
||||
]
|
||||
},
|
||||
]
|
||||
with patch.object(LargeFileS3, "_client", backend):
|
||||
reader = LargeFileS3("model")
|
||||
assert reader.version == 9
|
||||
assert [instance.version for instance in reader._instances] == [0, 9]
|
||||
assert backend.list_objects_v2.call_args_list[0].kwargs["Prefix"] == "model/"
|
||||
assert (
|
||||
backend.list_objects_v2.call_args_list[1].kwargs["ContinuationToken"] == "next"
|
||||
)
|
||||
|
|
|
|||
Loading…
Reference in a new issue