Apply literal contains filters consistently to numeric and textual fields

This commit is contained in:
Andras Schmelczer 2026-10-27 19:57:42 +00:00
commit c5bf7d4a7d
2 changed files with 96 additions and 10 deletions

View file

@ -5,10 +5,10 @@ from pathlib import Path
from typing import Any
from unittest.mock import patch
from tinydb.table import Table
from great_ai import ParallelTinyDbDriver, Trace
from great_ai.context import get_context
from great_ai.views import Filter
from tinydb.table import Table
def write_traces(path: str, index: int, barrier: Any) -> None:
@ -74,3 +74,45 @@ def test_tinydb_date_queries_normalize_timezones(isolated_context: None) -> None
noon = datetime(2026, 1, 1, 12, tzinfo=timezone.utc)
assert database.query(since=noon, until=noon)[1] == 2
assert database.query(since=noon.replace(hour=13))[1] == 0
def test_contains_handles_numbers_and_literal_punctuation(
isolated_context: None,
) -> None:
database = get_context().tracing_database
database.save(
Trace(
trace_id="contains",
created="2026-01-01",
original_execution_time_ms=2.5,
models=[],
tags=[],
logged_values={"text": "A[2.5"},
)
)
for property, value in (
("original_execution_time_ms", 2.5),
("text", "["),
("text", 2.5),
("text", "a["),
):
assert (
database.query(
conjunctive_filters=[
Filter(property=property, operator="contains", value=value)
]
)[1]
== 1
)
assert (
database.query(
conjunctive_filters=[
Filter(
property="original_execution_time_ms",
operator="contains",
value="[",
)
]
)[1]
== 0
)

View file

@ -1,10 +1,10 @@
from datetime import datetime, timedelta, timezone
from typing import Any, Iterator, Tuple
from unittest.mock import MagicMock, patch
from unittest.mock import patch
import pytest
from great_ai import MongoDbDriver
from great_ai.views import Filter
@pytest.fixture
@ -44,3 +44,24 @@ def test_empty_batch_is_a_noop(mongo: Tuple[MongoDbDriver, Any]) -> None:
driver, collection = mongo
assert driver.save_batch([]) == []
collection.insert_many.assert_not_called()
def test_mongo_contains_uses_literal_case_insensitive_patterns(
mongo: Tuple[MongoDbDriver, Any],
) -> None:
driver, collection = mongo
driver.query(
conjunctive_filters=[Filter(property="text", operator="contains", value="a[")]
)
assert {
"text": {"$regex": r"a\[", "$options": "i"}
} in collection.find.call_args.kwargs["filter"]["$and"]
numeric = driver._get_filter(
Filter(property="score", operator="contains", value=2.5)
)
assert numeric == {
"$or": [
{"score": {"$eq": 2.5}},
{"score": {"$regex": r"2\.5", "$options": "i"}},
]
}